Bobafett fix #577
Merged
Bobafett fix #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add comments - use enum for timing values - rename "accel" to "lateralAccel"
This partially undoes a change from commit 28a91f3 The result is the same, but the refactored code is easier to reason through and debug
The interval for switching directions in figure8 mode should have its own enum. It should not depend on whether the facing-player fix is enabled. Set the shoot delay to 291 ticks regardless of whether the facing-player fix is enabled. If the delay is halved, he shoots more frequently and becomes very hard to fight. In both cases, we are sticking with the DOS values
yAccel/thrustMax should be thrustFactor (a value that the thrustScale is multiplied by) thrustPitch should be an ANGLE14_32 rather than FIXED16_16
luciusDXL
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main thing is to fix the bug that breaks his thrust/flying.
A line was erroneously added in commit 6ab2d35, setting the thrustPitch to
ONE_16(1440 degrees), which then causes the thrust to oscillate wildly with a sinusoidal pattern.Took the opportunity to refactor the code for readability, add more enums, fix some variable names, add more comments