Sort operation needs by presence of default value #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
approved these changes
Dec 22, 2025
Member
jwoertink
left a comment
jwoertink
left a comment
There was a problem hiding this comment.
oh sweet! Thanks for fixing that 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1118
This fixes a compilation error where an operation is made with a
needthat has a default value and there are needs defined after it without a default. I'm not sure if it matters, butOPERATION_NEEDSwill be in a different order now. All needs without a default value will be in the reverse order they were defined and at the front of the list, and needs with a default value will be in the order they were defined but at the end of the list. If the ordering needs to be maintained, everywhere that uses the list in the needy initializer files will need to sort it first.