Use actual names for Generics instead of T #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void name collisions. Fixes #836
Member
matthewmcgarvey
left a comment
matthewmcgarvey
left a comment
There was a problem hiding this comment.
I'm not so sure about AvramModel because it hides that it's a generic.
Is it possible to use _T or _Avram_T or something like that?
Member
Author
|
Yeah, I debated on this too. I originally went with |
robacarp
approved these changes
Jul 22, 2022
Contributor
robacarp
left a comment
robacarp
left a comment
There was a problem hiding this comment.
I have no problem with this. I don't think it's opaque to call it AvramModel, thats what it would look like if it were a type alias, and that's essentially what this is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836
There's a ton of places where
Tgets used, so I'll have to take some time to think out if all of them are necessary to change, or if just the ones where named collisions can happen....