Apply Upstream Commit: windowscodecs: BitmapScaler_CopyPixels: Do not demand a larger buffer than necessary. #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than necessary. Only `bytesperrow` bytes are written to each row of the output rect. Therefore the last row need not be padded to `cbStride` bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains a bugfix related to bitmap scaling. It fixes the CopyPixels function rejecting parameters that are valid on windows, where the destination bitmap buffer doesn't include padding for the last scanline. This behavior is relied upon by DirectXTex's mipmap generation.
This commit fixes the black texture problem in BeamNG.drive reported in ValveSoftware/Proton#1237
This commit has just been merged into proton experimental bleeding-edge (here).