Refactor: Update txiki.js version and unify binary fetching #51

sunnyswag · 2025-11-14T06:21:22Z

Dependencies

txiki.js: Updated to v24.12.0+ (required for Response.blob() support and fix compile error quickjs-ng/quickjs#1031)

Changes

Unify image fetching with blob support
- Standardized to use blob().arrayBuffer() pattern (requires txiki.js blob support)
- Extracted common fetchBinary() utility in helpers.ts
- Updated Image, GIF components and style post-processing to use shared function
Code cleanup
- Removed redundant Buffer.from() conversions
- Renamed getImageBinary → fetchBinary for better clarity
Fix JS_IsArray API usage
- Changed JS_IsArray(ctx, obj) → JS_IsArray(obj) to match QuickJS API

Summary by cubic

Updated txiki.js to enable blob-based fetches and unified binary loading for Image, GIF, and style assets. Adds opt-in LVGL focus navigation via default groups and a static library build option with configurable display resolution and LVGL config directory.

Dependencies
- Updated txiki.js to v24.12.0+ for Response.blob() support and to resolve quickjs-ng compile issue.
Refactors
- Unified binary fetching via fetchBinary (blob().arrayBuffer()) with HTTP error handling; replaced getImageBinary/getGIFBinary and Buffer.from; updated Image, GIF, background-image, and arc-image to use it.
- Implemented LVGL group focus navigation: added GroupManager; View gets groupType prop (AddChildToDefGroup/AddCurToDefGroup) and setInGroupType; added onFocusedStyle; removed auto lv_group_add_obj from constructors; manage membership on append/remove and reorder default group to match UI order; simulator sets the default group for keyboard/encoder.
- Fixed JS_IsArray calls to match the QuickJS API (no ctx) and added stricter argc/type checks.
- Added BUILD_STATIC_LIB and split engine into EngineInit/EngineRun with a new main.cpp for executable builds.
- Made display resolution configurable via CMake (DISP_HOR_RES/DISP_VER_RES) and applied in device init/buffer sizing; added LVGLJS_CONF_DIR for a custom LVGL config directory and updated docs.
- Minor: bool literal fixes, test image path updates, and compile_commands.json added to .gitignore.

^{Written for commit 90e252a. Summary will update on new commits.}

…tructure

…F and Image components

cubic-dev-ai

6 issues found across 20 files

Prompt for AI agents (all 6 issues)


Understand the root cause of the following 6 issues and fix them.


<file name=".gitignore">

<violation number="1" location=".gitignore:11">
Remove the trailing space so the ignore pattern matches `compile_commands.json`.</violation>
</file>

<file name="test/image/1/index.jsx">

<violation number="1" location="test/image/1/index.jsx:9">
The new relative path points to test/image/1/test/image/1/1.png, but only test/image/1/1.png exists, so the image will fail to load at runtime.</violation>
</file>

<file name="src/render/react/utils/helpers.ts">

<violation number="1" location="src/render/react/utils/helpers.ts:18">
fetchBinary should surface HTTP failures before decoding the body so callers don’t process error pages as binary data.</violation>
</file>

<file name="src/render/native/components/line/line_wrap.cpp">

<violation number="1" location="src/render/native/components/line/line_wrap.cpp:17">
The guard still allows argc==1, but the code below reads argv[1], which is out of bounds when only one argument is passed. Tighten the check to avoid undefined behavior/crashes.</violation>
</file>

<file name="src/render/native/components/dropdownlist/dropdownlist_wrap.cpp">

<violation number="1" location="src/render/native/components/dropdownlist/dropdownlist_wrap.cpp:16">
This guard should ensure argc &gt;= 2 before reading argv[1]; otherwise the native function reads beyond the QuickJS argument list when only one argument is supplied.</violation>
</file>

<file name="src/render/native/components/roller/roller_wrap.cpp">

<violation number="1" location="src/render/native/components/roller/roller_wrap.cpp:16">
Accessing argv[1] and argv[2] requires verifying argc &gt;= 3; otherwise calls with fewer arguments read beyond the QuickJS argv array and can crash native code.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

.gitignore

test/image/1/index.jsx

src/render/react/utils/helpers.ts

src/render/native/components/line/line_wrap.cpp

src/render/native/components/dropdownlist/dropdownlist_wrap.cpp

src/render/native/components/roller/roller_wrap.cpp

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

cubic-dev-ai

No issues found across 1 file

…rror messaging

cubic-dev-ai

No issues found across 1 file

sunnyswag · 2026-01-01T08:53:27Z

I have fixed all the issues. Please review @derekstavis, thanks!

sunnyswag · 2026-01-05T07:15:26Z

Hi! Could someone review my PR? This repo needs several improvements before it's production-ready: fixing memory leaks and compilation warnings, improving runtime efficiency and render speed, refactoring the architecture, adding device benchmarks, etc. Our team wants to use this in production and I would like to help improve it. @derekstavis @kisvegabor

…y point - Introduced option to build lvgljs as a static library. - Refactored engine initialization and execution into separate functions. - Updated CMakeLists.txt and Makefile to accommodate new build configurations. - Added main.cpp as the entry point for executable builds.

…e initialization

…esolution options

cubic-dev-ai

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="CMakeLists.txt">

<violation number="1" location="CMakeLists.txt:11">
P2: LV_CONF_PATH is cached and can become stale if LVGLJS_CONF_DIR is changed, leaving the build using the wrong lv_conf.h.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-01-13T04:19:12Z

CMakeLists.txt

+    set(LVGLJS_CONF_DIR ${CMAKE_CURRENT_SOURCE_DIR}/deps CACHE INTERNAL "LVGLJS_CONF_DIR")
+endif()
+
+set(LV_CONF_PATH ${LVGLJS_CONF_DIR}/lv_conf.h CACHE INTERNAL "LV_CONF_PATH")


P2: LV_CONF_PATH is cached and can become stale if LVGLJS_CONF_DIR is changed, leaving the build using the wrong lv_conf.h.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At CMakeLists.txt, line 11: <comment>LV_CONF_PATH is cached and can become stale if LVGLJS_CONF_DIR is changed, leaving the build using the wrong lv_conf.h.</comment> <file context> @@ -3,7 +3,12 @@ cmake_minimum_required(VERSION 3.16) + set(LVGLJS_CONF_DIR ${CMAKE_CURRENT_SOURCE_DIR}/deps CACHE INTERNAL "LVGLJS_CONF_DIR") +endif() + +set(LV_CONF_PATH ${LVGLJS_CONF_DIR}/lv_conf.h CACHE INTERNAL "LV_CONF_PATH") set(BUILD_NATIVE OFF CACHE BOOL "Build wasm3 with native support") </file context>

- Add GroupManager singleton to manage lv_group_t instances - Modify BasicComponent appendChild/removeChild to handle group membership - Add unregisterContainer call in BasicComponent destructor - Remove auto lv_group_add_obj from all component constructors (21 files) - Add setInGroup method to View component for JS binding - Add DefaultGroup constant in React layer - Add group prop support in View React component - Add onFocusedStyle support in CommonComponentApi - Add test case in test/group/1/index.jsx

cubic-dev-ai

2 issues found across 31 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/render/react/components/View/comp.ts">

<violation number="1" location="src/render/react/components/View/comp.ts:21">
P2: Group membership cannot be unset: once set it remains registered even if the group prop is removed or changed, leading to stale native state.</violation>
</file>

<file name="src/render/native/core/group/group_manager.cpp">

<violation number="1" location="src/render/native/core/group/group_manager.cpp:46">
P2: Auto-edit mode isn’t reset when the group becomes empty (or holds a non-editable single object), so editing can stay true after removals, leaving the group in a stale editing state with no focused object.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-01-13T13:13:52Z

src/render/react/components/View/comp.ts

 function setViewProps(comp, newProps: ViewProps, oldProps: ViewProps) {
  const setter = {
    ...CommonComponentApi({ compName: "View", comp, newProps, oldProps }),
+    group(g) {


P2: Group membership cannot be unset: once set it remains registered even if the group prop is removed or changed, leading to stale native state.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/render/react/components/View/comp.ts, line 21: <comment>Group membership cannot be unset: once set it remains registered even if the group prop is removed or changed, leading to stale native state.</comment> <file context> @@ -6,15 +6,23 @@ import { function setViewProps(comp, newProps: ViewProps, oldProps: ViewProps) { const setter = { ...CommonComponentApi({ compName: "View", comp, newProps, oldProps }), + group(g) { + if (g === DefaultGroup) { + comp.setInGroup(true); </file context>

✅ Addressed in 90e252a

cubic-dev-ai · 2026-01-13T13:13:52Z

src/render/native/core/group/group_manager.cpp

+    if (!group) return;
+
+    uint32_t count = lv_group_get_obj_count(group);
+    if (count == 1) {


P2: Auto-edit mode isn’t reset when the group becomes empty (or holds a non-editable single object), so editing can stay true after removals, leaving the group in a stale editing state with no focused object.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/render/native/core/group/group_manager.cpp, line 46: <comment>Auto-edit mode isn’t reset when the group becomes empty (or holds a non-editable single object), so editing can stay true after removals, leaving the group in a stale editing state with no focused object.</comment> <file context> @@ -0,0 +1,55 @@ + if (!group) return; + + uint32_t count = lv_group_get_obj_count(group); + if (count == 1) { + lv_obj_t* focused = lv_group_get_focused(group); + if (focused && lv_obj_is_editable(focused)) { </file context>

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="demo/viewpager/index.tsx">

<violation number="1" location="demo/viewpager/index.tsx:42">
P2: Active page state never updates when the pager is scrolled directly, so the dots and prev/next logic desync from the visible page</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-01-14T16:38:07Z

demo/viewpager/index.tsx

+    <View style={style.root}>
+      <View
+        ref={pagerRef}
+        style={style.pager}


P2: Active page state never updates when the pager is scrolled directly, so the dots and prev/next logic desync from the visible page

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At demo/viewpager/index.tsx, line 42: <comment>Active page state never updates when the pager is scrolled directly, so the dots and prev/next logic desync from the visible page</comment> <file context> @@ -0,0 +1,180 @@ + <View style={style.root}> + <View + ref={pagerRef} + style={style.pager} + > + {Array.from({ length: pageCount }).map((_, i) => ( </file context>

- Introduced AddChildToDefGroup and AddCurToDefGroup symbols for group type management. - Updated View component to support groupType prop for specifying group behavior. - Modified GroupManager to handle new group types and improve child management. - Refactored BasicComponent methods to integrate with the new group system. - Updated documentation and examples to reflect changes in group handling.

cubic-dev-ai

1 issue found across 13 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/render/react/core/group/index.ts">

<violation number="1" location="src/render/react/core/group/index.ts:4">
P2: `AddToDefGroupType` collapses to `symbol` because `Symbol.for` returns plain `symbol`, so the intended two-token union is not enforced and any symbol type is accepted.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-01-15T04:09:38Z

src/render/react/core/group/index.ts

+export const AddChildToDefGroup = Symbol.for('AddChildToDefGroup');
+export const AddCurToDefGroup = Symbol.for('AddCurToDefGroup');
+
+export type AddToDefGroupType = typeof AddChildToDefGroup | typeof AddCurToDefGroup;


P2: AddToDefGroupType collapses to symbol because Symbol.for returns plain symbol, so the intended two-token union is not enforced and any symbol type is accepted.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/render/react/core/group/index.ts, line 4: <comment>`AddToDefGroupType` collapses to `symbol` because `Symbol.for` returns plain `symbol`, so the intended two-token union is not enforced and any symbol type is accepted.</comment> <file context> @@ -1,2 +1,11 @@ +export const AddChildToDefGroup = Symbol.for('AddChildToDefGroup'); +export const AddCurToDefGroup = Symbol.for('AddCurToDefGroup'); + +export type AddToDefGroupType = typeof AddChildToDefGroup | typeof AddCurToDefGroup; + +export function toNativeInGroupType(g?: AddToDefGroupType): 0 | 1 | undefined { </file context>

sunnyswag added 4 commits November 11, 2025 12:21

chore: update .gitignore to include compile_commands.json for clangd

60fc3fa

fix: update image paths in test components to use correct directory s…

69f2ddb

…tructure

chore: update txiki subproject to latest commit to support fetch blob

b4817d7

refactor: replace getBinary functions with fetchBinary utility for GI…

36cffee

…F and Image components

cubic-dev-ai bot reviewed Nov 14, 2025

View reviewed changes

Update .gitignore

1b8da28

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

cubic-dev-ai bot reviewed Nov 14, 2025

View reviewed changes

fix: enhance fetchBinary function to handle HTTP errors and improve e…

ec284e1

…rror messaging

cubic-dev-ai bot reviewed Nov 14, 2025

View reviewed changes

sunnyswag force-pushed the master branch from 8c3ce41 to ec284e1 Compare January 12, 2026 03:34

huanghuiqing added 3 commits January 12, 2026 16:09

build: add display resolution configuration to CMake and update devic…

78c3560

…e initialization

build: enhance CMake configuration with LVGLJS_CONF_DIR and display r…

a92a974

…esolution options

cubic-dev-ai bot reviewed Jan 13, 2026

View reviewed changes

huanghuiqing and others added 2 commits January 14, 2026 12:01

refactor: extract init_input_devices for indev init

053617d

demo: add flex ViewPager demo (ts)

1b17f0c

cubic-dev-ai bot reviewed Jan 14, 2026

View reviewed changes

huanghuiqing added 2 commits January 15, 2026 12:04

feat: add arc test code

41ed000

cubic-dev-ai bot reviewed Jan 15, 2026

View reviewed changes

sunnyswag closed this Jan 16, 2026

Refactor: Update txiki.js version and unify binary fetching #51

Refactor: Update txiki.js version and unify binary fetching #51

Uh oh!

Conversation

sunnyswag commented Nov 14, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sunnyswag commented Jan 1, 2026

Uh oh!

sunnyswag commented Jan 5, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sunnyswag commented Nov 14, 2025 •

edited by cubic-dev-ai bot

Loading

cubic-dev-ai bot Jan 13, 2026 •

edited

Loading

cubic-dev-ai bot Jan 13, 2026 •

edited

Loading