Skip to content

Conversation

@morganiq
Copy link

@morganiq morganiq commented Mar 8, 2015

To allow vertical expansion of the container below the fold for content tall enough to do so, look for an optional value of min-height and, if present, set that property instead of height. Includes README update.

Note: CoffeeScript edits untested. Manually edited and tested JavaScript source only.

@m43nu
Copy link
Owner

m43nu commented Mar 12, 2015

Thanks for your addition!
I checked your CoffeeScript source and it won't work like this, though..

You need to change the code to:
property = if $attrs.autoHeight == 'min-height' then 'min-height' else 'height'

If you can make this change by yourself, I will test and merge the PR afterwards.

@morganiq
Copy link
Author

Fixed! Sorry, forgot about this PR for a while.

@m43nu
Copy link
Owner

m43nu commented Apr 1, 2015

Thank you for fixing it.

I will check it out later today.

@severinraez
Copy link

hi morganiq

i just talked to m43nu about this stalled request - the cause we didn't merge it yet is the remaining merge conflicts. would you mind fixing them? alternatively we'll do - sometime ;)

Conflicts:
	dist/auto-height.js
	src/auto-height.coffee
@morganiq
Copy link
Author

morganiq commented Aug 3, 2015

Sorry again for the delay; I've merged the changes. Again, I manually edited and tested the JavaScript source only. CoffeeScript changes were eyeballed and are untested.

# Conflicts:
#	dist/auto-height.js
@morganiq
Copy link
Author

Updated with properly re-generated and disted auto-height.js, resolving the merge conflict. Manually tested in browser; should be good to merge now. Sorry for not keeping an eye on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants