2019 Cordova Update #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 20, 2019 15:51
Cordova plugins as of 2019 requrie a package.json file. I don't know how this will work if merged back into the main repo since this file points to my forked repo.
AFAIK this plugin was/is meant to add video playback on Android which (amazingly) is still an Android limitation/issue as of 2019. Other platforms (iOS, Windows? etc) don't need help with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have this working as of 2019/11 in a Cordova Android app. However the package.json file is currently pointing my fork URL not the main repo. I'm not sure how this will work if this pull request is merged in - will the URLs auto update to use the original/main repo or will they need to be manually adjusted after the merge? Just mentioning this in case you don't want to merge or post-merge edits are necessary.