Modernize FLEX: iOS 16+, remove private APIs, reduce size #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madibb
changed the title
Replace private continuousCorners/setContinuousCorners: with iOS 13+ public cornerCurve API. Remove _setWidth: usage which is a private API. This fixes ITMS-90338 App Store rejection for non-public API usage. Changed: - CALayer+FLEX.m: Use cornerCurve instead of continuousCorners KVC - FLEXArgumentInputTextView.m: Use cornerCurve directly instead of setValue:forKey: - UIBarButtonItem+FLEX.h: Remove _setWidth: declaration - FLEXTableViewController.m: Remove _setWidth: call
- Wrap uses of UIScreen.mainScreen in FLEXMacros.h with clang diagnostic to ignore deprecated-declarations warning - Add FLEXFileBrowserController.h to FLEX.h umbrella header and mark as public in Xcode project to fix module umbrella header warning Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
madibb
force-pushed
the
fix/remove-private-apis
branch
from
13e3acd to
4e17213
Compare
…ation Major changes: - Remove Keychain viewer (~52K) - Remove DatabaseBrowser (~124K) - Remove RuntimeBrowser (~164K) - Remove SystemLog viewer (~88K) - Replace embedded PNG icons with SF Symbols in FLEXResources.m (~820K) FLEXResources.m reduced from 8,861 lines (828K) to 266 lines (8K) using SF Symbols and programmatic drawing. Updated minimum iOS deployment target to iOS 13 (SF Symbols requirement). See REFACTORING_LOG.md for detailed change documentation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…checks - Update minimum deployment target from iOS 9 to iOS 16 in podspec, Package.swift, and project settings - Remove all @available(iOS X, *) version checks for iOS versions < 16 - Remove all API_AVAILABLE(ios(X)) annotations for iOS versions < 16 - Simplify code paths that were conditional on older iOS versions - Remove -Wno-unsupported-availability-guard compiler flag (no longer needed) - Update README.md to reflect iOS 16 requirement APIs now used unconditionally: UIWindowScene, NSURLSessionWebSocketTask, UIMenu, UISelectionFeedbackGenerator, UNUserNotificationCenter, NSKeyedUnarchiver secure coding, NSDirectionalEdgeInsets, UIScrollView.adjustedContentInset Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
madibb
changed the title
These design source assets (Sketch file, PNGs, conversion scripts) are no longer needed since FLEXResources now uses SF Symbols. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
madibb
changed the title
- globalsIcon: list.bullet → line.3.horizontal (hamburger menu) - hierarchyIcon: square.stack.3d.up → square.grid.2x2 (grid) - recentIcon: clock → doc.badge.clock (clipboard with clock) - Done button: checkmark circle → red xmark Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Icons: - dragHandle: dots → line.3.horizontal with padding - globalsIcon (menu): line.3.horizontal → wrench - hierarchyIcon (views): square.stack.3d.up → square.grid.2x2 - recentIcon: clock → doc.badge.clock Done button: - Replace blue checkmark circle with red xmark across all screens - Update duplicate button detection for new styling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes FLEX for iOS 16+ by removing private APIs, reducing library size by ~1.25MB, and cleaning up legacy iOS version checks.
Impact: 115 files changed, 760 additions, 17,632 deletions (~16.8K lines removed)
Changes
1. Private API Removal
Removes usage of private APIs that were causing App Store submission rejections.
2. Xcode 26 SwiftPM Build Warnings Fix
Xcode 26 treats warnings in SPM headers as project-level warnings, causing issues for projects with "warnings as errors" enabled.
Fixes:
UIScreen.mainScreeninFLEXMacros.hwithclang diagnostic ignored "-Wdeprecated-declarations"FLEXFileBrowserController.htoFLEX.humbrella header and mark as public3. Library Size Reduction (~1.25MB)
Removed modules:
SF Symbols migration:
FLEXResources.m: 8,861 lines → 266 lines (99% reduction)4. iOS 16+ Minimum Deployment Target
@available(iOS X, *)version checks for iOS < 16API_AVAILABLE(ios(X))annotations for iOS < 16-Wno-unsupported-availability-guardcompiler flagAPIs now used unconditionally:
UIWindowSceneand scene-based APIsNSURLSessionWebSocketTaskfor websocket monitoringUIMenuand context menu APIsUISelectionFeedbackGeneratorfor haptic feedbackUNUserNotificationCenterfor push notification inspectionNSKeyedUnarchiversecure coding APIsNSDirectionalEdgeInsetsand layout APIsFeatures Still Available
After these changes, FLEX still provides:
References
How to build
Use script:
buildFlex.sh