ensure _source_branch is never a tag #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're releasing to the CPAN where your HEAD is also tagged,
_source_branch's default would populate the attribute with the tag name.
This is sub-optimal, and tends to result in things like:
fatal: update_ref failed for ref 'refs/heads/build/tags/0.006^0': refusing to update ref with bad name 'refs/heads/build/tags/0.006^0'
The fix is to constrain the set of refs name-rev uses to name a commit
to the set of branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're releasing to the CPAN where your HEAD is also tagged,
_source_branch's default would populate the attribute with the tag name. This
is sub-optimal, and tends to result in things like:
The fix is to constrain the set of refs name-rev uses to name a commit
to the set of branches.
...why would we ever do this? Well, imagine a situation where a TRIAL/dev
release has been cut and deemed satisfactory; it's possible a release would be
cut directly, without any changes from the previous release.