Restrict this parameters to Self-like types in declare_class!
#523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
bug
madsmtm
force-pushed
the
restrict-this-declare-class
branch
from
8743e4f to
33e7f1a
Compare
madsmtm
changed the title
this parameters to Self-like typesthis parameters to Self-like types in declare_class!
Also refactor declare class internals slightly
madsmtm
force-pushed
the
restrict-this-declare-class
branch
from
33e7f1a to
8c6b293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to allow e.g.
this: &NSStringindeclare_class!, since that'd not be valid withself: &NSString(and is very likely unsound and undesired anyhow).Also refactor declare class internals in preparation for #521.