-
Notifications
You must be signed in to change notification settings - Fork 1
release: v0.2.0 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v0.2.0 #15
Conversation
|
Warning Rate limit exceeded@GabrielePicco has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 34 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughPackage version updated from 0.1.0 to 0.2.0. CI workflow no longer scopes steps to Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer (push)
participant GH as GitHub Actions
participant OS as Runner (Ubuntu)
rect rgb(230,245,255)
Dev->>GH: push event triggers publish-crate.yml
end
rect rgb(245,255,230)
GH->>OS: checkout repository
OS->>GH: repo at root
end
rect rgb(255,245,230)
GH->>OS: setup Rust toolchain (no --profile minimal)
GH->>OS: install packages: protobuf-compiler (new)
end
rect rgb(230,255,245)
Note over GH,OS: Previously: steps ran with working-directory: rust/ (scoped into subdir)
Note over GH,OS: Now: steps run from repository root (changed)
end
rect rgb(245,230,255)
GH->>OS: run lint/build/test/publish from repo root
OS->>GH: build/test/publish results
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/publish-crate.yml(5 hunks)format-cargo-lock.sh(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.8)
.github/workflows/publish-crate.yml
77-77: shellcheck reported issue in this script: SC2086:info:10:64: Double quote to prevent globbing and word splitting
(shellcheck)
77-77: shellcheck reported issue in this script: SC2086:info:10:78: Double quote to prevent globbing and word splitting
(shellcheck)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test-and-build
🔇 Additional comments (2)
.github/workflows/publish-crate.yml (2)
61-62: Verify cargo-build-sbf installation timing and availability.The
cargo-build-sbfinstallation occurs in the publish job but runs before any Rust toolchain caching or setup. Ensure that the Rust installation from theinstalljob is properly cached and available in this context, and thatcargo-build-sbfinstallation doesn't conflict with the upstream dependency installation.Does the Rust cache from the
installjob (line 29-30) carry over to thepublishjob? If not, you may need to reinstall or cache Rust explicitly in thepublishjob before installingcargo-build-sbf.
37-37: Verify working directory change from rust/ to ./ is intentional and correct.The working directory changed from
rust/(implied in the old workflow) to./(repo root). Confirm that Cargo.toml and the Rust project structure are at the repository root, and that all cargo commands (fmt, clippy, build) are intended to run from this location.
5f3b1c0 to
6afe68a
Compare
fixed: solana-program 3.0.0 has type conflicts causing dependency issue for other dependencies since solana-program is not capped.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
✏️ Tip: You can customize this high-level summary in your review settings.