Skip to content

Conversation

@jonasXchen
Copy link
Contributor

@jonasXchen jonasXchen commented Nov 22, 2025

fixed: solana-program 3.0.0 has type conflicts causing dependency issue for other dependencies since solana-program is not capped.

Summary by CodeRabbit

  • Chores
    • Version bump to 0.2.0
    • Updated CI/build pipeline: added an additional build tool and adjusted workflow steps to run build, test, and publish from the repository root (streamlined install and execution flow)

✏️ Tip: You can customize this high-level summary in your review settings.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 22, 2025

Warning

Rate limit exceeded

@GabrielePicco has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 493ff3f and 480da4d.

📒 Files selected for processing (1)
  • .github/workflows/publish-crate.yml (1 hunks)

Walkthrough

Package version updated from 0.1.0 to 0.2.0. CI workflow no longer scopes steps to rust/, removes the Rust toolchain --profile minimal flag, and adds installation of protobuf-compiler to the workflow.

Changes

Cohort / File(s) Change Summary
Version bump
Cargo.toml
package.version changed from 0.1.0 to 0.2.0
CI workflow
.github/workflows/publish-crate.yml
Added protobuf-compiler installation; removed --profile minimal from Rust toolchain installation; removed explicit working-directory: rust/ so lint/build/test/publish steps run from repository root

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer (push)
    participant GH as GitHub Actions
    participant OS as Runner (Ubuntu)

    rect rgb(230,245,255)
    Dev->>GH: push event triggers publish-crate.yml
    end

    rect rgb(245,255,230)
    GH->>OS: checkout repository
    OS->>GH: repo at root
    end

    rect rgb(255,245,230)
    GH->>OS: setup Rust toolchain (no --profile minimal)
    GH->>OS: install packages: protobuf-compiler (new)
    end

    rect rgb(230,255,245)
    Note over GH,OS: Previously: steps ran with working-directory: rust/ (scoped into subdir)
    Note over GH,OS: Now: steps run from repository root (changed)
    end

    rect rgb(245,230,255)
    GH->>OS: run lint/build/test/publish from repo root
    OS->>GH: build/test/publish results
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check that running steps from repository root still locates the Rust crate (Cargo.toml) and any expected paths.
  • Verify the publish step uses the intended crate path and that removing --profile minimal is acceptable for CI runtime.
  • Confirm protobuf-compiler installation is necessary and available on the runner image.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'release: v0.2.0' directly corresponds to the version bump from 0.1.0 to 0.2.0 in Cargo.toml and aligns with the PR's primary objective of releasing version 0.2.0 to fix solana-program dependency issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f2566d and 4683b8e.

📒 Files selected for processing (2)
  • .github/workflows/publish-crate.yml (5 hunks)
  • format-cargo-lock.sh (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.8)
.github/workflows/publish-crate.yml

77-77: shellcheck reported issue in this script: SC2086:info:10:64: Double quote to prevent globbing and word splitting

(shellcheck)


77-77: shellcheck reported issue in this script: SC2086:info:10:78: Double quote to prevent globbing and word splitting

(shellcheck)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test-and-build
🔇 Additional comments (2)
.github/workflows/publish-crate.yml (2)

61-62: Verify cargo-build-sbf installation timing and availability.

The cargo-build-sbf installation occurs in the publish job but runs before any Rust toolchain caching or setup. Ensure that the Rust installation from the install job is properly cached and available in this context, and that cargo-build-sbf installation doesn't conflict with the upstream dependency installation.

Does the Rust cache from the install job (line 29-30) carry over to the publish job? If not, you may need to reinstall or cache Rust explicitly in the publish job before installing cargo-build-sbf.


37-37: Verify working directory change from rust/ to ./ is intentional and correct.

The working directory changed from rust/ (implied in the old workflow) to ./ (repo root). Confirm that Cargo.toml and the Rust project structure are at the repository root, and that all cargo commands (fmt, clippy, build) are intended to run from this location.

@jonasXchen jonasXchen merged commit cffcfeb into master Nov 22, 2025
6 checks passed
@bmuddha bmuddha deleted the release/v0.2.0 branch December 26, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants