New spell language #71
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new language can be used by using a .spell extension instead of .json
Example rewrite of Gong Strike:
Significant features not showcased are combining conditions with
&&, inverting conditions (is_falseshouldn't be used directly), addingen_preds, andper_entity_hit:Selectors can also be combined with
||:Oh yeah and entities:
Requires mahjerion/Library-of-Exile-Rework#8
KNOWN ISSUE: constructs like
if (!(cond1() && cond2()))orif (cond1() && cond2()) { } else { }don't work properly because mns doesn't yet support OR in conditions, which this is equivalent to