ida: use Domain API for interacting with the IDA Python SDK

[williballenthin]

Checklist

• No CHANGELOG update needed

• No new tests needed

• No documentation update needed

[github-actions]

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

[gemini-code-assist]

Summary of Changes

Hello @williballenthin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the IDA Pro feature extraction component by transitioning its internal data access mechanisms to the ida_domain API. This change aims to enhance the maintainability and clarity of the codebase by providing a more Pythonic and structured way to interact with IDA's database, moving away from direct, lower-level SDK calls. The refactoring ensures that all feature extraction logic consistently uses the new API, preparing the groundwork for future improvements and better integration with IDA's evolving Python ecosystem.

Highlights

• Migration to IDA Domain API: The core feature extraction logic for IDA Pro has been refactored to utilize the new ida_domain Python API. This involves importing the Database object and passing it explicitly through various extraction functions, replacing direct calls to older idaapi, idc, and idautils functions.
• Centralized Database Access: The IdaFeatureExtractor now takes a Database object during initialization, and new class methods from_current_database() and from_file() are introduced to provide structured ways to obtain this database handle, ensuring consistent and explicit access to IDA's data model.
• Updated Feature Extraction Signatures: Almost all feature extraction functions across basicblock.py, extractor.py, file.py, function.py, global_.py, and insn.py have been updated to accept the db: Database argument, allowing them to interact with IDA's data through the modern ida_domain interface.
• Improved Helper Functions: Helper functions in helpers.py have been significantly updated to leverage ida_domain for tasks such as finding byte sequences, iterating functions and segments, reading bytes, checking for recursive functions, and more, leading to a more robust and potentially performant interaction with IDA's database.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully migrates the IDA feature extraction logic to use the new ida_domain API, replacing many direct idaapi and idc calls. This significantly modernizes the codebase and should improve maintainability and potentially robustness. The changes are consistently applied across the affected files, with the Database object being correctly passed as a parameter to relevant functions and stored as an instance variable in the IdaFeatureExtractor. The introduction of factory methods (from_current_database, from_file) in the extractor is a good design choice for managing the Database instance lifecycle.

[gemini-code-assist]

The seg parameter in check_segment_for_pe is missing a type hint. It should likely be ida_domain.segments.Segment for clarity and type safety.

[gemini-code-assist]

The seg parameter in get_segment_buffer is missing a type hint. It should likely be ida_domain.segments.Segment for clarity and type safety.