fix: add conditional statement into __exit__ method #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yangeok
commented
May 9, 2024
|
|
||
| def __exit__(self, exc_type, exc_value, traceback): | ||
| self.rollback() | ||
| if exc_type: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, manukanne.
Found your blog posts and code repository very helpful for implementing DDD with fastapi, sqlmodel. I've been using the uow related code as-is, but I noticed that the rollback keeps getting executed. Upon investigation, I found some suggested code improvements, so I'll be sending a PR.
Modified the code
rollbackis only executed in the method__exit__when an exception occurs.Thanks again. Have a great day.