trying out pre commit hook [TEST] #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnomadb
commented
Jun 6, 2018
tests/test_blob_func.py
Outdated
| for i in range(3): | ||
| timg[i, rRowInds[0]: rRowInds[1], rColInds[0]: rColInds[1]] = 100 | ||
| timg[-1, rRowInds[0]: rRowInds[1], rColInds[0]: rColInds[1]] = 255 | ||
| timg[i, rRowInds[0] : rRowInds[1], rColInds[0] : rColInds[1]] = 100 |
Contributor
Author
There was a problem hiding this comment.
black is adding these, which flake8 does not like. @perrygeo @sgillies @normanb @vincentsarago seen this before? Also is doing the same on a dummy file:
an_indexable_list = list(range(10))
a = [1]
b = [3]
c = [5]
an_indexable_list[a[0]:b[0]]
an_indexable_list[b[0]:c[0]]Is black formatted to
an_indexable_list = list(range(10))
a = [1]
b = [3]
c = [5]
an_indexable_list[a[0] : b[0]]
an_indexable_list[b[0] : c[0]]This only occurs when the indexing variable is itself indexed, ie this passes both:
an_indexable_list = list(range(10))
a = 1
b = 3
c = 5
an_indexable_list[a:b]
an_indexable_list[b:c]
perrygeo
suggested changes
Nov 9, 2018
| rev: v1.2.3 | ||
| hooks: | ||
| - id: flake8 | ||
| args: [--max-line-length=88] |
Contributor
There was a problem hiding this comment.
we need to sync the pre-commit config with PXM's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.