feat: support GPS timestamps #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to the
mapillary_toolspackage, focusing on refactoring and improving the handling of GPS data points. The most significant changes involve replacing thegeo.PointWithFixclass with the newGPSPointclass and updating related methods and imports accordingly.Refactoring and improvements to GPS data handling:
mapillary_tools/exiftool_read_video.py: Replacedgeo.PointWithFixwithGPSPointin various methods, updated imports to includeGPSFixandGPSPoint, and adjusted the attributes in theGPSPointclass. [1] [2] [3] [4] [5] [6] [7] [8]mapillary_tools/geo.py: Removed theGPSFixenum andPointWithFixclass, along with the deprecated_ecef_from_lla_DEPRECATEDfunction andgroup_everyfunction. [1] [2]mapillary_tools/geotag/geotag_videos_from_exiftool_video.py: Updated methods to useGPSPointinstead ofgeo.PointWithFix. [1] [2]mapillary_tools/geotag/geotag_videos_from_video.py: Updated methods to useGPSPointinstead ofgeo.PointWithFix. [1] [2]mapillary_tools/geotag/gpmf_gps_filter.py: Updated methods to useGPSPointinstead ofgeo.PointWithFixand adjusted attribute names accordingly. [1] [2] [3] [4] [5]mapillary_tools/geotag/gpmf_parser.py: Updated methods to useGPSPointinstead ofgeo.PointWithFix, added functions to handle GPS timestamps, and adjusted attribute names accordingly. [1] [2] [3] [4] [5] [6] [7]