-
Notifications
You must be signed in to change notification settings - Fork 9
Add Fedora RPM packaging support and improve CI workflows #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mapitman
wants to merge
32
commits into
main
Choose a base branch
from
fedora-package
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
a1d7e78
Automate building an RPM package
mapitman 682fddd
Update method for determining version
mapitman 50461e4
Force go build to not attempt to embed VCS info
mapitman 64951ed
Fix RPM build error
mapitman 578ba29
Fix RPM build errors
mapitman 436a533
Try to fix build error
mapitman 2398b6f
Try to fix build error again
mapitman a586442
fix(ci): stream repo into containers for ci-sim targets to avoid moun…
mapitman 4da88bb
chore(ci): mark ci simulation scripts executable
mapitman 7835571
fix(ci): sanitize VERSION for rpm builds (replace illegal chars)
mapitman fd0f3b9
fix(ci): pass expanded RPM_VERSION to rpmbuild and fix echo
mapitman c43b481
ci: stop building RPMs on every push (handled in release workflow)
mapitman 8acab0a
ci: remove duplicate rpm-build workflow (release handles RPMs)
mapitman 6caf2fe
fix(ci): mark repo safe for git before RPM build to fix git archive
mapitman 1d51e2e
docs: consolidate documentation into fewer files
mapitman c1fd679
Initial plan
Copilot 0f6b0b5
fix(ci): add workflow_dispatch trigger with version input to build wo…
Copilot 3a6bf08
Update Makefile
mapitman 7a54117
Update Makefile
mapitman cb1fa3f
Update Makefile
mapitman 10642be
Update Makefile
mapitman fb698bf
Update build-rpm.sh
mapitman 48e8276
Update scripts/ci-sim-fedora.sh
mapitman 3907608
Update scripts/ci-sim-ubuntu.sh
mapitman 0b7e1f9
Improve dependency checking with actual command names
Copilot b04a4c1
Improve comment clarity in check_dependencies
Copilot 90c6e52
Fix tar command to handle VERSION with forward slashes
Copilot 41fbafb
fix: correct tar transform syntax to use proper sed-style delimiters
Copilot fa0745e
fix(ci): sanitize VERSION to replace slashes with dashes
Copilot 6a443e4
Merge branch 'fedora-package' into copilot/sub-pr-43
Copilot e352cda
refactor(ci): remove redundant VERSION sanitization from workflow
Copilot aa9347b
Merge pull request #44 from mapitman/copilot/sub-pr-43
mapitman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,3 +12,4 @@ parts/ | |
| package/* | ||
| *.deb | ||
| mdview.1 | ||
| dist/ | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow checks for workflow_dispatch event but the workflow does not declare workflow_dispatch in its triggers (only push is declared). This means the condition will never be true, and the github.event.inputs.version will never be used. Either add workflow_dispatch to the trigger list or remove this unused conditional logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback