feat(broadcastNodeStatus): send node status to everyone #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gau-thier
force-pushed
the
feat/broadcastNodeStatus
branch
from
75434f1 to
ef6daca
Compare
…oadcastNodeStatus
…oadcastNodeStatus
Gau-thier
changed the title
Gau-thier
force-pushed
the
feat/broadcastNodeStatus
branch
from
45d0dee to
61d257e
Compare
rosalogia
reviewed
Jun 1, 2022
| let send_ping_request_to node (recipient : Peer.t) = | ||
| send_message (PingRequest recipient.address) node recipient | ||
|
|
||
| let broadcast_message message node = |
Contributor
There was a problem hiding this comment.
We will have to change this to take advantage of the disseminator 😄
rosalogia
approved these changes
Jun 1, 2022
Contributor
|
This looks good, but as mentioned we need to adapt it to dissemination, so not merge-ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #31 "still need to be done"