feat(dekuIntegration): add sign_payload and key #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gau-thier
force-pushed
the
feat/dekuIntegration
branch
2 times, most recently
from
ed3aa7b to
e28d82f
Compare
Gau-thier
force-pushed
the
feat/dekuIntegration
branch
from
e28d82f to
bbe64b2
Compare
Gau-thier
commented
May 31, 2022
Gau-thier
commented
May 31, 2022
lib/pnode/pnode.mli
Outdated
| val init : | ||
| ?preprocess:(Message.t -> Message.t) -> | ||
| msg_handler:(Message.t -> bytes) -> | ||
| msg_handler:(Message.t -> bytes * bytes option) -> |
Collaborator
Author
There was a problem hiding this comment.
I though a lot (too much) about this, I think making msg_handler returning a bytes * bytes option (where payload:bytes and payload_signature:bytes option) is the best option.
What do you think @rosalogia?
Contributor
There was a problem hiding this comment.
Since responses will become optional as well, it will probably be bytes option * bytes option. I think that's fine!
Contributor
|
Can we merge #33 first? 😅 I don't mind being the one to rebase this PR after that. |
rosalogia
approved these changes
Jun 1, 2022
Collaborator
Author
Of course 😉 |
Gau-thier
force-pushed
the
feat/dekuIntegration
branch
from
8870703 to
595d99c
Compare
Gau-thier
force-pushed
the
feat/dekuIntegration
branch
from
595d99c to
788e99d
Compare
Collaborator
Author
|
Closing in favor of #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For some messages, Deku needs to sign the payload
Proposal
Make
msg_handlerreturning a tuple(payload, payload_signature)of typebytes * bytes option