Move background processes to an Lwt.async context #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add post category * Derive show for debugging purposes * Add timestamp for checking if message is out of date * Make recipients an Address.t list so that messages can be constructed without recipients, then have recipients added later on * Add message hashing for easily checking if a message has been seen before
This module is essentially a "dissemination manager". It keeps track of plenty of useful state info regarding what messages are being sent out, for how long they should continue to be sent out, and which messages shouldn't be interacted with anymore.
…ve certain modules/functions to testing submodules
rosalogia
force-pushed
the
@rosalogia/async-background-processes
branch
from
ed11dde to
0906408
Compare
Gau-thier
approved these changes
Jun 14, 2022
Collaborator
Gau-thier
left a comment
Gau-thier
left a comment
There was a problem hiding this comment.
This is a good change!
I accept, but tests seems to fail, once they are fixed, this can be merged.
rosalogia
force-pushed
the
@rosalogia/gossip-dissemination
branch
from
a9866a3 to
ec351dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address #51 by moving certain "background processes" such as sending messages for failure detection and dissemination out of the server and into an
Lwt.asynccall. This means the server can block as much as it wants waiting for new messages and handling them before continuing. The original reason for this was to remove the fixed interval between server iterations due to the fact that messages were being received/handled in a separate thread which was not being awaited. However, I have found that this approach does not actually allow us to remove the fixed interval. It is still necessary for the interval to be there in the function called withLwt.async, or things begin to stall. I am not sure if this change is desirable.