Skip to content

Conversation

@quicken
Copy link

@quicken quicken commented Sep 29, 2013

Added a patch for compatibility with open bluedragon 3.0

The recurse and filter options for cfdirectory work differently in
openbd. Added a compatibility component which uses a custom method to
emulate the same behaviour for cfdirectoy in openbluedragon.

Changed the keys for META_ABSTRACT and META_GENERIC as openbluedragon
throws an error when a structure key name contains a colon.

The patch has been tested with openbd 3.0 and Railo 4

Added a patch for compatibility with open bluedragon 3.0

The recurse and filter options for cfdirectory work differently in
openbd. Added a compatibility component which uses a custom method to
emulate the same behaviour for cfdirectoy in openbluedragon.

Changed the keys for META_ABSTRACT and META_GENERIC as openbluedragon
throws an error when a structure key name contains a colon.

The patch has been tested with openbd 3.0 and Railo 4
@markmandel
Copy link
Owner

So unless I'm mistaken, this is a breaking change? As it changes colddoc:abstract -> colddoc_abstract, which would break other people's documentation. Would that be correct?

@quicken
Copy link
Author

quicken commented Sep 30, 2013

Ahh, yes I only just realized that colddoc:abstract is a feature for doing extra annotations. So oops that is correct it's a breaking change.

I guess I really should log a bug report with the open bluedragon guys for what ever reason it's possible to dump the output of the component meta data and the colddoc:abstract keys are show with the correct values in the dump
however as soon as they are reference with strFoo["colddoc:abstract"] an exception is thrown. The bluedragon server just does not like a colon in the keyname of the struct returned by the meta functions.

A possibility would be to just wrap the colddoc:abstract definition in another if block that checks for openblueragon.

any thoughts?

Just thought I'd share the code throw it in the bin, use it, does not matter much to me.

cheers

Marcel

On 30/09/2013, at 10:09 AM, Mark Mandel notifications@github.com wrote:

So unless I'm mistaken, this is a breaking change? As it changes colddoc:abstract -> colddoc_abstract, which would break other people's documentation. Would that be correct?


Reply to this email directly or view it on GitHub.

@markmandel
Copy link
Owner

Unless you want to write a way to switch it out - or better yet - support either option

@markmandel markmandel closed this Oct 1, 2013
@markmandel markmandel reopened this Oct 1, 2013
@markmandel
Copy link
Owner

Sorry - didn't mean to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants