Get $env easier with $self->env #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update some POD, Repo URL, Version
Add notes for older commits.
Add Scalar::Util to requires, See MartinMcGrath@5a135b0
Add other perl versions to .travis.yml
This reverts commit 0e5d6e1.
This reverts commit e0463bd.
Get $env easier with $self->env if CGI::Application is used as PSGI Application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Martin,
I test at the moment the dev branch with a very basic PSGI Application. And I thought it could be a good idea to get $env easier through $self->env.
I know one can get it through $self->query->env, but I think becaus of the importance of the $env hash in PSGI Application, an own method is justified...
I propose that the $env can be pass in the new method new('ENV' => $env) and in the run_as_psgi($env) method. The first should no backward compatibility problem. The second can lead to some conflicts with plugins and modules (at least the comment in the run_as_psgi function says that some plugins need special arguments..)