make stackview always scroll #77
Open
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarielChen
commented
Apr 26, 2020
Comment on lines
+38
to
+39
| edgesForExtendedLayout = [] | ||
| navigationController?.navigationBar.isTranslucent = false |
Author
There was a problem hiding this comment.
make view's top equals navigationBar's bottom
| setUpHiddenRows() | ||
| setUpExpandingRowView() | ||
| setUpHorizontalRow() | ||
| // when hide PhotoRow stackview can also scroll |
Comment on lines
+43
to
+56
|
|
||
| open override func viewDidLayoutSubviews() { | ||
| super.viewDidLayoutSubviews() | ||
| if stackViewCanAlwaysScroll { | ||
| if stackView.contentSize.height < view.frame.size.height { | ||
| var bottomPadding: CGFloat = 0 | ||
| if #available(iOS 11.0, *) { | ||
| bottomPadding = UIApplication.shared.keyWindow?.safeAreaInsets.bottom ?? 0 | ||
| } | ||
| // contentSize height need to bigger than view height | ||
| stackView.contentSize = CGSize(width: 0, height: view.frame.size.height - bottomPadding + 0.5) | ||
| } | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
mark stackView always scroll
Comment on lines
+67
to
+71
|
|
||
| /// When true, stackView can always scroll | ||
| /// | ||
| /// Default is `true`. | ||
| open var stackViewCanAlwaysScroll = true |
Author
There was a problem hiding this comment.
bool value for stackViewCanAlwaysScroll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like tableview. When stackView content size is less than view height, it can also scroll.