Skip to content

Conversation

@last-partizan
Copy link

@last-partizan last-partizan commented Jan 25, 2022

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

This PR reverts https://github.com/maroider/winit/pull/1/files , not becouse it was bad or broken, but becouse i found real reason behind those strange modifiers behaviour, and maybe that PR fixed it, but it has added something to complexity.

Real reason: there was two places to track modifier states, and i removed one. There was three places to track modifiers (well, two in modifiers.rs and on in XkbState).

Maybe there was reason for this, which i don't know, but removing it simplified code and i used neovide with this change for a day, and not found any downsides.

Maybe this was stupid idea at all, but please take a look. And, maybe this changes should be combined with #1 instead of reverting, but i'll want you feedback before doing so.

@last-partizan last-partizan marked this pull request as draft January 29, 2022 13:54
@last-partizan last-partizan force-pushed the fix-modifiers-maroider-pr branch from b0a4cb8 to 495148c Compare January 29, 2022 21:05
@last-partizan last-partizan force-pushed the fix-modifiers-maroider-pr branch from 495148c to db2d8ac Compare January 29, 2022 21:14
@last-partizan
Copy link
Author

This is updated version, where i found there is three places which are storing modiers. So, i removed utils/modifiers.rs, and are using ModifiersState::from_x11 where possible, and where impossible - i'm using from_xkb_modifiers.

@last-partizan
Copy link
Author

Looks like it was already fixed by #6

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant