Another attempt to fix modifier keys behaviour #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to usersThis PR reverts https://github.com/maroider/winit/pull/1/files , not becouse it was bad or broken, but becouse i found real reason behind those strange modifiers behaviour, and maybe that PR fixed it, but it has added something to complexity.
Real reason:
there was two places to track modifier states, and i removed one.There was three places to track modifiers (well, two in modifiers.rs and on in XkbState).Maybe there was reason for this, which i don't know, but removing it simplified code and i used
neovidewith this change for a day, and not found any downsides.Maybe this was stupid idea at all, but please take a look. And, maybe this changes should be combined with #1 instead of reverting, but i'll want you feedback before doing so.