Skip to content

per batch feedback Update train_mu_controller.py #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smilesun wants to merge 4 commits into
base: fbopt
Choose a base branch
from
Open

per batch feedback Update train_mu_controller.py #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
127b2ae
Update train_mu_controller.py
smilesun Oct 12, 2023
6de2f35
Update a_trainer.py
smilesun Oct 12, 2023
cb351f7
Update train_mu_controller.py
smilesun Oct 12, 2023
529a055
fix conflic
smilesun Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions domainlab/algos/trainers/a_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ def __init__(self, successor_node=None):
self.epo_loss_tr = None
self.epo_reg_loss_tr = None
self.epo_task_loss_tr = None
self.batch_loss_tr = None
self.batch_reg_loss_tr = None
self.batch_task_loss_tr = None
self.counter_batch = None
self.hyper_scheduler = None
self.optimizer = None
Expand Down
11 changes: 10 additions & 1 deletion domainlab/algos/trainers/train_fbopt_b.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,15 @@ def before_batch(self, epoch, ind_batch):
should be set to epoch*self.num_batches + ind_batch
"""
if self.flag_update_hyper_per_batch:
self.hyper_scheduler.search_mu(
self.epo_reg_loss_tr,
self.epo_task_loss_tr,
self.epo_loss_tr,
self.list_str_multiplier_na,
miter=epoch)
self.set_model_with_mu()
# NOTE: if not update per_batch, then not updated
self.model.hyper_update(epoch * self.num_batches + ind_batch, self.hyper_scheduler)
# self.model.hyper_update(epoch * self.num_batches + ind_batch, self.hyper_scheduler)
return super().after_batch(epoch, ind_batch)

def before_tr(self):
Expand Down Expand Up @@ -117,6 +124,8 @@ def tr_epoch(self, epoch, flag_info=False):
"""
update multipliers only per epoch
"""
if not self.flag_update_hyper_per_batch:
return super().tr_epoch(epoch)
self.hyper_scheduler.search_mu(
self.epo_reg_loss_tr,
self.epo_task_loss_tr,
Expand Down