Copilot/add comprehensive testing

[benbalter]

Testing and CI Enhancements:

• Added a detailed TESTING.md guide covering test coverage, running tests, coverage reporting, mocking strategies, and best practices for contributing tests. This will help new contributors understand and maintain the test suite.
• Introduced a GitHub Actions CI workflow in .github/workflows/ci.yml that runs tests on Python 3.11 and 3.12, checks code formatting and linting, and performs type checking. Coverage reports are uploaded to Codecov.

DLC Upload Improvements:

• Enhanced DLCManager.upload_dlc to support an optional async progress callback, increased the default upload timeout to 5 minutes, and improved internal progress tracking. This enables better feedback for long-running uploads and more robust error handling. [1] [2] [3] [4] [5]

CLI and Code Quality Improvements:

• Improved error handling in the CLI by chaining exceptions with raise typer.Exit(1) from e for better tracebacks and debugging. [1] [2] [3] [4]
• Minor code cleanups and import order fixes in pyfluff/cli.py and pyfluff/__init__.py for clarity and style consistency. [1] [2] [3] [4] [5] [6]

These updates collectively improve the maintainability, usability, and reliability of the PyFluff codebase.

[Copilot]

Pull Request Overview

This PR adds comprehensive DLC (DownLoadable Content) management functionality to PyFluff, including a complete web UI, backend API endpoints, extensive test coverage, and CI/CD configuration. The changes enable users to upload custom DLC files to Furby Connect via a modern web interface with real-time progress tracking.

Key changes:

• Complete DLC management web UI with progress tracking via WebSocket
• New FastAPI endpoint for one-click "flash and activate" workflow
• Async file I/O optimizations for better DLC upload performance
• 114 new tests achieving 37% overall coverage (100% for core protocol/models)
• GitHub Actions CI/CD pipeline with testing, linting, and type checking

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
web/index.html	Adds DLC management UI section with file upload, slot selection, and advanced controls
web/style.css	Adds styling for DLC UI including progress bars, buttons, and animations
web/app.js	Implements DLC upload logic, WebSocket progress tracking, and event handlers
pyfluff/server.py	Adds /dlc/flash-and-activate endpoint and WebSocket for progress updates
pyfluff/dlc.py	Adds flash_and_activate() method and async file I/O with progress callbacks
pyfluff/furby.py	Adds device info caching and concurrent BLE reads for performance
pyfluff/furby_cache.py	Adds async file I/O and batched writes for cache operations
pyfluff/protocol.py	Reformats FURBY_NAMES dict and adds missing name entry (Tay-Tah)
tests/*	Adds 114 tests across 4 new test files for protocol, models, cache, and DLC
.github/workflows/ci.yml	Adds CI/CD pipeline with Python 3.11/3.12 testing matrix
TESTING.md	Comprehensive testing documentation with examples and best practices
pyproject.toml	Updates ruff config to ignore B008 and B904 for specific use cases

[Copilot]

The offset variable is never incremented inside the loop, causing progress calculation to always be 0%. Add offset += len(chunk) after line 144 to track bytes uploaded correctly.

[Copilot]

Lines 103 and 106 are duplicate assertions checking the same value. Remove the duplicate assertion at line 106.

Suggested change

assert cmd[1] == 0x00

[Copilot]

Two redundant comments on consecutive lines describing the same thing. Merge into a single clear comment: # Check size bytes (3 bytes, big-endian, offset by 1 due to 0x00 byte)

Suggested change

	# Check size bytes (big-endian) - note offset by 1 due to 0x00 byte
	# Check size bytes (big-endian, 3 bytes)
	# Check size bytes (3 bytes, big-endian, offset by 1 due to 0x00 byte)

[Copilot]

[nitpick] The inline comment states 'Must set event to unblock the wait', but this applies to all error paths (lines 54, 57, 59). Consider moving this explanation to a docstring or single comment above the error handling block to avoid repetition and improve clarity.

See below for a potential fix:

            # In all error paths, must set the event to unblock any waiters.
            elif mode == FileTransferMode.FILE_RECEIVED_ERROR:
                self._transfer_error = "File transfer failed"
                self._transfer_complete.set()
            elif mode == FileTransferMode.FILE_TRANSFER_TIMEOUT:
                self._transfer_error = "File transfer timeout"
                self._transfer_complete.set()