-
Notifications
You must be signed in to change notification settings - Fork 103
Fix panicparse for Go 1.23 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
- Coverage 83.4% 78.5% -4.9%
=======================================
Files 12 23 +11
Lines 2768 3070 +302
=======================================
+ Hits 2308 2409 +101
- Misses 399 583 +184
- Partials 61 78 +17 ☔ View full report in Codecov by Sentry. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Go 1.21 changed how the runtime prints deep stacks: golang/go@9eba17f fixes maruel#90
|
Hey @maruel, I got the tests to pass :) Please take a look at this PR when you get a chance. Thank you! |
maruel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to update the tests!
bd41618 to
ec2c673
Compare
(With 1.17.13, the tests would not even compile.)
ec2c673 to
aa2551a
Compare
|
Tests passed, so this should be ready to merge now :) Thanks |
maruel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
These changes make panicparse work with Go 1.23.