Skip to content

Conversation

@stapelberg
Copy link
Contributor

@stapelberg stapelberg commented Feb 9, 2025

These changes make panicparse work with Go 1.23.

@codecov
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.5%. Comparing base (496cdd2) to head (aa2551a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main     #92     +/-   ##
=======================================
- Coverage   83.4%   78.5%   -4.9%     
=======================================
  Files         12      23     +11     
  Lines       2768    3070    +302     
=======================================
+ Hits        2308    2409    +101     
- Misses       399     583    +184     
- Partials      61      78     +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Go 1.21 changed how the runtime prints deep stacks:
golang/go@9eba17f

fixes maruel#90
@stapelberg stapelberg changed the title WIP: Fixes for Go 1.23 Fix panicparse for Go 1.23 Feb 9, 2025
@stapelberg stapelberg marked this pull request as ready for review February 9, 2025 18:19
@stapelberg
Copy link
Contributor Author

Hey @maruel, I got the tests to pass :) Please take a look at this PR when you get a chance. Thank you!

Copy link
Owner

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to update the tests!

(With 1.17.13, the tests would not even compile.)
@stapelberg
Copy link
Contributor Author

Tests passed, so this should be ready to merge now :) Thanks

Copy link
Owner

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maruel maruel merged commit 9264a04 into maruel:main Feb 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants