Don’t post-process the MessageFormat output in __mf
#546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output from the MessageFormat compiled function may contain arbitrary user-provided content, and cannot safely be re-parsed as an interval string, Mustache template, or printf format string. Fixes mashpie#544. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
mf-postprocess
branch
from
85d6dd8 to
0e7d0da
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
==========================================
- Coverage 98.17% 97.99% -0.18%
==========================================
Files 2 2
Lines 548 549 +1
==========================================
Hits 538 538
- Misses 10 11 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
thanks again... :) as the current implementation with enabled post-processing is in use for more than a decade, I would consider this a breaking change which requires a new release plus fallback opt-in to enable legacy behavior and docs. There is at least one other PR that I wanted to merge before pushing new releases. So stay tuned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output from the
MessageFormatcompiled function may contain arbitrary user-provided content, and cannot safely be re-parsed as an interval string, Mustache template, orprintfformat string.__mfincorrectly re-parses output as Mustache #544.