Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 25 additions & 15 deletions .github/workflows/lint-cpp-objc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,29 +21,39 @@ concurrency: ${{ github.workflow }}-${{ github.ref }}
jobs:
lint-cpp-objc:
name: Lint cpp and objc
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout Repo
uses: actions/checkout@v4
with:
fetch-depth: 0

# https://dev.to/mayankpareek/introducing-ci-pipeline-for-clang-format-checks-in-faker-cxx-35go
- name: Cache clang-format dependencies
uses: actions/cache@v4
- name: Setup Node.js
uses: actions/setup-node@v4
with:
path: /tmp/apt-cache
key: clang-format-${{ runner.os }}-${{ hashFiles('**/apt-packages.txt') }}
restore-keys: |
clang-format-${{ runner.os }}-
cache: 'yarn'
node-version: 20

- name: Install clang-format
run: |
if [ ! -f /tmp/apt-cache/clang-format-16 ]; then
sudo apt-get update
sudo apt-get install -y clang-format-16
touch /tmp/apt-cache/clang-format-16
fi
- name: Install dependencies
run: yarn install --immutable
shell: bash

# https://dev.to/mayankpareek/introducing-ci-pipeline-for-clang-format-checks-in-faker-cxx-35go
# - name: Cache clang-format dependencies
# uses: actions/cache@v4
# with:
# path: /tmp/apt-cache
# key: clang-format-${{ runner.os }}-${{ hashFiles('**/apt-packages.txt') }}
# restore-keys: |
# clang-format-${{ runner.os }}-

# - name: Install clang-format
# run: |
# if [ ! -f /tmp/apt-cache/clang-format-16 ]; then
# sudo apt-get update
# sudo apt-get install -y clang-format-16
# touch /tmp/apt-cache/clang-format-16
# fi

- name: Run clang-format
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/lint-js-typecheck.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ concurrency: ${{ github.workflow }}-${{ github.ref }}
jobs:
lint-js-typecheck:
name: JS lint and typecheck
runs-on: ubuntu-24.04
steps:
- name: Checkout Repo
uses: actions/checkout@v4
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/test-cpp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,22 @@ concurrency: ${{ github.workflow }}-${{ github.ref }}
jobs:
test-cpp:
name: Run GTest suite
runs-on: ubuntu-24.04
steps:
- name: Checkout Repo
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup Node.js
uses: actions/setup-node@v4
with:
cache: 'yarn'
node-version: 20

- name: Install dependencies
run: yarn install --immutable
shell: bash

- name: Run GTest
run: yarn test:cpp:prepare
1 change: 1 addition & 0 deletions .github/workflows/test-js.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ concurrency: ${{ github.workflow }}-${{ github.ref }}
jobs:
test-js:
name: Run Jest suite
runs-on: ubuntu-24.04
steps:
- name: Checkout Repo
uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions encoding-core/ReactNativeEncodingBase64.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#pragma once

#include <cstdint>
#include <string>

std::string decodeFromBase64BufferToUtf8String(const uint8_t *data, size_t size);
Expand Down
1 change: 1 addition & 0 deletions encoding-core/ReactNativeEncodingHex.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#pragma once

#include <cstdint>
#include <sstream>
#include <string>

Expand Down