Skip to content
This repository was archived by the owner on Jul 21, 2025. It is now read-only.

Conversation

@reivilibre
Copy link
Contributor

@reivilibre reivilibre commented May 12, 2025

This takes the proxy test introduced in #375 and:

  • replaces the nginx forward proxy (which doesn't currently have an AMD64 latest release :S) with a mitmproxy with some hardcoded dummy responses, so we don't need to configure FCM credentials and hit the real FCM API
    • so now you can run the proxy test with minimal faff
  • makes curl.sh exit with a failure status if the Sygnal request doesn't give 200 OK
  • adds CI code that spawns the Compose setup and then exercises curl.sh, resulting in a success or fail
    • this involves building the dockerfile in more situations than we did before, so caching is now enabled for the docker build
    • we also have to export and import the container image as an 'artifact' to ferry it across jobs

@reivilibre reivilibre force-pushed the rei/auto_ci_proxy_test branch 13 times, most recently from a8a6749 to 1233f5e Compare May 12, 2025 15:54
@reivilibre reivilibre force-pushed the rei/auto_ci_proxy_test branch from 1233f5e to 44658ab Compare May 12, 2025 15:57
@reivilibre reivilibre force-pushed the rei/auto_ci_proxy_test branch from 44658ab to cc620e8 Compare May 12, 2025 16:18
@reivilibre reivilibre marked this pull request as ready for review May 12, 2025 16:18
@reivilibre reivilibre requested a review from a team as a code owner May 12, 2025 16:18
Copy link
Contributor

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, the changes look great!
Just a couple small comments.

@reivilibre reivilibre requested a review from a team July 1, 2025 09:35
Copy link
Contributor

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Hopefully this squashes any future proxy issues from appearing in Sygnal without getting caught in CI.

@devonh devonh merged commit 9c9e5c5 into main Jul 14, 2025
7 checks passed
@devonh devonh deleted the rei/auto_ci_proxy_test branch July 14, 2025 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants