This repository was archived by the owner on Jul 21, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 155
Modify proxy test to use mocked FCM API and test it in CI #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8a6749 to
1233f5e
Compare
1233f5e to
44658ab
Compare
44658ab to
cc620e8
Compare
devonh
reviewed
May 21, 2025
Contributor
devonh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, the changes look great!
Just a couple small comments.
devonh
approved these changes
Jul 14, 2025
Contributor
devonh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Hopefully this squashes any future proxy issues from appearing in Sygnal without getting caught in CI.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the proxy test introduced in #375 and:
latestrelease :S) with a mitmproxy with some hardcoded dummy responses, so we don't need to configure FCM credentials and hit the real FCM APIcurl.shexit with a failure status if the Sygnal request doesn't give 200 OKcurl.sh, resulting in a success or fail