Add in scalable UART ports #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt001k
requested changes
Apr 17, 2023
| CLITXCallback_t tx; | ||
| CLI_BUF_VALUE_T *buf; | ||
| CLI_BUF_COUNT_VALUE_T bufc; | ||
| PORT_ENUM_T port; |
Owner
There was a problem hiding this comment.
Where is this defined at? In the config file? Can you add that to the example config if so.
Also, prepend this with CLI so we have CLI_PORT_ENUM_T please.
Owner
There was a problem hiding this comment.
The README should also be updated to reflect the changes in the function pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding port as an argument for the having the CLI framework on multiple UART ports.