Skip to content

Add support for rows #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mattlean wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Add support for rows #4

mattlean wants to merge 31 commits into from

Conversation

@mattlean
Copy link
Owner

@mattlean mattlean commented May 27, 2020 •
edited
Loading

  • Implemented rows
  • Minor UI updates
  • Fixed bug where validations for grid height calculations were always failing
  • Fixed bug where incorrect calculations occur when top and bottom margin values are updated
  • Fixed bug where column width wasn't recalculated when floor values flag or canvas size is changed
  • Fixed bug where margins were not adjusted when they did not fit perfectly on the canvas
  • Fixed bug where crash occurs when columns are set to 1

@mattlean mattlean self-assigned this May 27, 2020
mattlean added 17 commits May 26, 2020 18:13
@mattlean
Fix bug where some row stats are swapped
a815f55
@mattlean
Merge branch 'master' into rows2
7425c61
@mattlean
Update features in README
c7b3861
@mattlean
Update features in README
957208e
@mattlean
Fix bug where canvas width and height values swap when updating manua…
14575f4 
…l row values
@mattlean
Merge branch 'rows2' of https://github.com/mattlean/gridnik into rows2
ac65f34
@mattlean
Fix bug where top & bottom margins blur event running attemptColGutte…
0018237 
…rWidthCalc instead of attemptGridHeightCalc
@mattlean
Fix bug where col draw errs if draw fields & gridlines aren't both se…
0e6e68d 
…lected
@mattlean
Fix bug where row draw errs if draw fields & gridlines aren't both se…
5a5147d 
…lected
@mattlean
Fix bug where draw fields & gridlines checkboxes are changed when cre…
1395f4c 
…ate cols & rows checkboxes are disabled
@mattlean
Update UI, update devDependencies
586836d 
- Rename col gutter width to gutter width & row gutter height to gutter height
- Hide col & row info when their create flags are set to false
- Move devDependencies that aren't supposed to be in dependencies
- Update transform-react-jsx plugin (mainly to handle fragments)
@mattlean
Recalculate col width or row height when floorVals or canvas size is …
148b5b7 
…changed
@mattlean
Progress on fixing margin calc bug
de9e4a7
@mattlean
Fix margin bug on rows
81c7f7d
@mattlean
Minor updates
8848420 
- Rename setLeft flag to updateLeftMargin
- Update JSDocs to doc updateLeftMargin
@mattlean
Fix bug with calc & update calc tests
be1868f 
- Fix bug where right & left margin sums were not being recalculated after being adjusted during calc
- Update Bootstrap grid tests to use accurate Bootstrap grid sizes
@mattlean
Test margin recalculation for calcColWidth
d46d5a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mattlean mattlean

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattlean