Fix media not loading due to trailing slash in homeserver URL #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
requested changes
Nov 25, 2024
JadedBlueEyes
force-pushed
the
auth-media
branch
from
04c967e to
bc16aa2
Compare
JadedBlueEyes
force-pushed
the
auth-media
branch
from
bc16aa2 to
d23711e
Compare
tulir
reviewed
Nov 25, 2024
JadedBlueEyes
changed the title
Author
|
Thanks for the quick review - I've stripped it down to the minimal changes. I reverted my attempt to update dependencies entirely - I'm not particularly familiar with electron's toolchain 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue I was having with media not showing up by stripping the trailing slash from the homeserver URL.
It also adds a proxy to deal with possible CORS issues fetching resources in development mode (in my case the bridge discovery).