Skip to content

Fix issue #104 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myadzel wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix issue #104 #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05056d5
provide show/hide functionality for tooltip message element
myadzel Nov 10, 2015
52f6430
hide tooltip message (previously opened) on bundle starts
myadzel Nov 10, 2015
d68e024
fix this, fix code style
myadzel Nov 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ function initialize () {
newGistId = newGist.user.login + '/' + newGistId
}
ui.$spinner.hide()
if (err) ui.tooltipMessage('error', err.toString())
if (err) ui.showTooltipMessage('error', err.toString())
if (newGistId) window.location.href = '/?gist=' + newGistId
})
})
Expand All @@ -131,7 +131,7 @@ function initialize () {
// if gistID is not set, fallback to specific queryParams, local storage
githubGist.getCode(gistID, function (err, code) {
ui.$spinner.hide()
if (err) return ui.tooltipMessage('error', JSON.stringify(err))
if (err) return ui.showTooltipMessage('error', JSON.stringify(err))

editors.init(code)
editors.setActive('bundle')
Expand Down Expand Up @@ -212,6 +212,7 @@ function initialize () {

sandbox.on('bundleStart', function () {
ui.$spinner.show()
ui.hideTooltipMessage()
})

sandbox.on('bundleEnd', function (bundle) {
Expand All @@ -220,7 +221,7 @@ function initialize () {

sandbox.on('bundleError', function (err) {
ui.$spinner.hide()
ui.tooltipMessage('error', 'Bundling error: \n\n' + err)
ui.showTooltipMessage('error', 'Bundling error: \n\n' + err)
})

if (parsedURL.query.save) return
Expand Down
46 changes: 32 additions & 14 deletions lib/ui-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,31 +23,49 @@ var controls = {
markdownBadgeTextarea.value = '[![view on requirebin](' + window.location.origin + '/badge.png)](' + window.location.origin + '/?gist=' + gistID + ')'
},
/**
* display error/warning messages in the site header
* cssClass should be a default bootstrap class
* @param {String} cssClass warning|alert|info|success
* @param text message content
* return alert element
*/
tooltipMessage: function (cssClass, text) {
getTooltipMessage: function () {
var message = document.querySelector('.alert')
if (message) {
message.classList.remove('hidden')
message.classList.add('alert-' + cssClass)
message.innerHTML = text
} else {
if (!message) {
message = document.createElement('div')
message.classList.add('alert')
message.className = 'alert'
var close = document.createElement('span')
close.classList.add('pull-right')
close.className.add('pull-right')
close.innerHTML = '&times'
close.addEventListener('click', function () {
this.parentNode.classList.add('hidden')
}, false)
message.classList.add('alert-' + cssClass)
message.innerHTML = text
document.querySelector('body').appendChild(message)
message.appendChild(close)
}
return message
},
/**
* alias for showTooltipMessage
*/
tooltipMessage: function (cssClass, text) {
return this.showTooltipMessage(cssClass, text)
},
/**
* display error/warning messages in the site header
* cssClass should be a default bootstrap class
* @param {String} cssClass warning|alert|info|success
* @param text message content
*/
showTooltipMessage: function (cssClass, text) {
var message = this.getTooltipMessage()
message.innerHTML = text
message.classList.add('alert-' + cssClass)
message.classList.remove('hidden')
},
/**
* hide and clean alert element
*/
hideTooltipMessage: function () {
var message = this.getTooltipMessage()
message.className = 'alert hidden'
message.innerHTML = ''
},

showForks: function (forks, parent) {
Expand Down