Upgrade to geoip2 5.0.1 and minor cleanup #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oschwald
commented
Jan 28, 2025
oschwald
commented
- Add basic ruff config
- Improve pyproject.toml organization
- Autofixes from ruff
- Unsafe fixes from ruff
- Add missing type hints and fix minor issues
- Correctly use MultipleInvalid
- Switch to geoip2 5
oschwald
force-pushed
the
greg/eng-1114
branch
from
15fc635 to
ba64caa
Compare
oschwald
force-pushed
the
greg/eng-1114
branch
2 times, most recently
from
58ac109 to
610e9b1
Compare
oschwald
force-pushed
the
greg/eng-1114
branch
from
610e9b1 to
ce35572
Compare
horgh
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.