auto-claude: 030-fix-broken-frontend-linting-setup-and-add-unit-tes #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mobile drawer) Added comprehensive unit tests for the ui-store Zustand store covering: - Initial state validation for all properties - setTheme function with all theme modes (light, dark, system) - toggleSidebar function and toggle behavior - toggleMobileDrawer function and toggle behavior - closeMobileDrawer function and idempotency - setMenuButtonElement function with element and null handling - State independence between different store actions - Persistence to localStorage for all state properties Tests follow project patterns from hooks tests and use vitest testing framework. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
… stream Added support for forwarding alert:triggered events in the SSE stream's realtime section. The events are forwarded directly to the client following the same pattern as message:translated events. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…m hook - Add onAlert callback to UseMessageStreamOptions interface - Handle alert:triggered events in SSE parsing loop - Log alert events to console for verification - Add onAlert to dependency array of connect callback Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…ation Added comprehensive E2E verification resources for real-time alert notifications: 1. e2e-alert-notification-test.sh - Automated test script - Checks prerequisites (backend, frontend, Redis, PostgreSQL) - Authenticates and creates test alert - Monitors Redis pub/sub and SSE stream - Provides step-by-step verification instructions - Includes cleanup procedures 2. E2E_ALERT_NOTIFICATION_VERIFICATION.md - Detailed manual testing guide - Complete architecture flow diagram - 10-step verification process with expected outcomes - Troubleshooting section for common issues - Performance, security, and accessibility checklists - Success criteria and test automation opportunities 3. ALERT_NOTIFICATION_CHECKLIST.md - Quick reference - Implementation verification summary - Code quality checklist - Quick 5-minute manual test procedure - Acceptance criteria Verification Flow: Alert Evaluation → Redis Pub/Sub → SSE Stream → Frontend → Toast Display These resources enable thorough E2E testing of the complete alert notification pipeline from backend trigger to frontend toast display. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
maynetee
deleted the
auto-claude/030-fix-broken-frontend-linting-setup-and-add-unit-tes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontend has an .eslintrc.json that references @typescript-eslint/parser and plugin:@typescript-eslint/recommended, but neither @typescript-eslint/eslint-plugin nor @typescript-eslint/parser are installed in package.json devDependencies. Running ESLint would immediately fail. Additionally, there is no Prettier configuration (no .prettierrc), no unit test framework (no Vitest/Jest), and the CI pipeline does not enforce linting. The only tests are 2 Playwright E2E test files. This means there are zero unit tests for custom hooks (use-message-stream.ts, use-message-polling.ts), Zustand stores, API utility functions, or complex components like collection-manager.tsx (317 lines).