Skip to content

Fixes: #166 Check location settings emits just a single value #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcharmas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes: #166 Check location settings emits just a single value #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...location/src/main/java/pl/charmas/android/reactivelocation2/ReactiveLocationProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public ReactiveLocationProvider(Context ctx) {
/**
* Creates location provider with custom handler in which all GooglePlayServices callbacks are called.
*
* @param ctx preferably application context
* @param ctx preferably application context
* @param handler on which all GooglePlayServices callbacks are called
* @see com.google.android.gms.common.api.GoogleApiClient.Builder#setHandler(android.os.Handler)
*/
Expand Down Expand Up @@ -312,7 +312,7 @@ public Observable<ActivityRecognitionResult> getDetectedActivity(int detectInter
* Observable that can be used to check settings state for given location request.
*
* @param locationRequest location request
* @return observable that emits check result of location settings
* @return observable that emits single check result of location settings
* @see com.google.android.gms.location.SettingsApi
*/
public Observable<LocationSettingsResult> checkLocationSettings(final LocationSettingsRequest locationRequest) {
Copy link
Owner Author

@mcharmas mcharmas Dec 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should change return type to Single as well.

Expand All @@ -322,7 +322,8 @@ public Observable<LocationSettingsResult> checkLocationSettings(final LocationSe
public Observable<LocationSettingsResult> apply(GoogleApiClient googleApiClient) {
return fromPendingResult(LocationServices.SettingsApi.checkLocationSettings(googleApiClient, locationRequest));
}
});
})
.take(1);
}

/**
Expand Down