Skip to content

Conversation

@smalho01
Copy link
Contributor

Describe your changes

migrate from auth number to case number instead

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-828

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

plarocque4
plarocque4 previously approved these changes Jun 13, 2025
export const orderSchema = new mongoose.Schema({
orderId: String,
caseNumber: String,
authNumber: String,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This authNumber didn't need to change as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I still kept it in the schema, but essentially it would always be set to an empty string now

@smalho01 smalho01 closed this Jun 13, 2025
@smalho01 smalho01 deleted the authNumber->caseNumber branch June 13, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants