Skip to content

Conversation

@smalho01
Copy link
Contributor

@smalho01 smalho01 commented Jun 12, 2025

Describe your changes

Add two urls to the spl zip and to the api return request - api return value configurable via env variables

SPL XML Format:

<subjectOf>
   <document>
   <id root="00000000-0000-0000-0000-000000000006"/>
   <title>REMS CDS Hooks Discovery Endpoint – HL7 4.0 - Prototype CDS Services</title>
   <text> <reference value="urn:HL7:FHIR4.0:rems_cds_discovery:http://rems-administrator:8090/"/>  </text>
   </document>
   <document>
   <id root="00000000-0000-0000-0000-000000000007"/>
   <title>REMS FHIR Base URL – HL7 4.0 - Prototype FHIR Server</title>
   <text> <reference value="urn:HL7:FHIR4.0:rems_fhir_base:http://rems-fhir-server:8091/"/>  </text>
   </document>
</subjectOf>

Issue ticket number and Jira link

REMS-829

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@plarocque4
Copy link
Contributor

Can you add that info from the review about the names of the variables in the zip to the README?

@plarocque4
Copy link
Contributor

We also need to standardize the names of the transactions so we can document it in the IG.
In the IG we only have rems_discovery which I'm assuming matches your rems_cds_discovery.

Copy link
Contributor

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we can update the documentation later.

@plarocque4 plarocque4 merged commit 2fc6825 into package-ndc-updates Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants