Skip to content

Conversation

@plarocque4
Copy link

Describe your changes

Add button to query for the PACIO patient discharge information and process the TOC.

Issue ticket number and Jira link

JIRA 859

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@@ -1,12 +1,11 @@
// Prefetch Template Source:
// https://build.fhir.org/ig/HL7/davinci-crd/hooks.html#prefetch
export class PrefetchTemplate {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did anything change in this file?

@@ -1,45 +1,44 @@
import { Button, Grid } from "@mui/material";
import { Button, Grid } from '@mui/material';
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any changes here?

// Determine which patient to use
let targetPatient = null;

if (configuredPatientId) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of a configured Patient ID? Shouldn't we read the patient from the TOC? Also, a Patient and any FHIR resource has an ID that is unique to the FHIR server, there is no point in trying to keep the patient ID the same as incoming data.

}
};

const clearResource =
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is called for all of the other clear resource buttons, like Task and QuestionnaireResponse, it calls the other function. Does this still work after the async changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants