Changes NTFSAccessEntry permission inheritance to be explicitly set #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2018 16:21
…will not preserve existing rules. Removed automatic change of folder inheritance. Fixed a problem when the folder owner was not System or a built-in group that causes the error "The security identifier is not allowed to be the owner of this object". Fixed a bug that caused the Test to report empty values for absent rules to remove and rules to be removed. Fixed a bug in Update-FileSystemRightsMapping that would add an additional phantom ACE when an inherited ACE had a permissions that used the generic permissions. In Compare-NtfsRule filtered the list of rules to be removed to only include non-inherited ACE rules to stop
…e. All the tests are created with DisableInheritance set so some additional test should be created to test this functionality. Fixed a bug in Set-TargetResource caused by $Expected not being initialised. Fixed a bug where removing rules was causing changes to the remaining rules for that Identity. Switched from using RemoveAccessRule to RemoveAccessRuleSpecific.
Codecov Report
@@ Coverage Diff @@
## Dev #36 +/- ##
==================================
+ Coverage 53% 53% +<1%
==================================
Files 5 5
Lines 959 965 +6
==================================
+ Hits 510 517 +7
+ Misses 449 448 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #35
I found some other problems when I was testing.
Fixed a problem when the folder owner was not System or a built-in group that causes the error "The security identifier is not allowed to be the owner of this object".
Fixed a bug that caused the Test to report empty values for absent rules to remove and rules to be removed.
Fixed a bug in Update-FileSystemRightsMapping that would add an additional phantom ACE when an inherited ACE had a permissions that used the generic permissions.
Fixed a bug in Set-TargetResource caused by $Expected not being initialised.
Fixed a bug where removing rules was causing changes to the remaining rules for that Identity. Switched from using RemoveAccessRule to RemoveAccessRuleSpecific.