Fix AttributeError and TypeError in light and pump state checks #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mdz
commented
Nov 4, 2025
mdz
commented
- Fix _wait_for_state_change to use get_status_method consistently from the start
- Add safety checks in SpaStateFull for None values in lights and pumps
- Resolves TypeError when iterating over None lights
- Resolves AttributeError when accessing pumps on SpaState
- Fix _wait_for_state_change to use get_status_method consistently from the start - Add safety checks in SpaStateFull for None values in lights and pumps - Resolves TypeError when iterating over None lights - Resolves AttributeError when accessing pumps on SpaState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.