Skip to content

Conversation

@WiseAndy
Copy link
Contributor

@WiseAndy WiseAndy commented Nov 28, 2017

Support for composer, based heavily on the work by @weemen @pmill and @tomgillett in PR #2 and #7 Closes #1

WiseAndy and others added 2 commits October 11, 2017 18:04
@WiseAndy WiseAndy requested a review from JoeEcob November 28, 2017 11:31
Copy link

@weemen weemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+93 -1052, that's a very good sign! If I would mention something then it would be missing unittests but maybe we should add them as a separate thing

@weemen
Copy link

weemen commented Nov 28, 2017

@WiseAndy how is this code tested? :)

@WiseAndy
Copy link
Contributor Author

@weemen Current manually tested for each release. Clearly not ideal, planning on introducing a set of unit tests in a subsequent release (across all our code wrappers)

Copy link

@JoeEcob JoeEcob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@WiseAndy WiseAndy merged commit 5a5e494 into master Nov 30, 2017
@WiseAndy WiseAndy deleted the composer branch November 30, 2017 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants