Skip to content

Conversation

@imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Jan 5, 2026

Description

Each batch run inside the migrate.py module could be called from a different thread (due to new scheduler) which would cause it to fail due to relying on thread id.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

closes #712

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Fix an issue where the migrate module would fail if returning more than 1000 results. #711
  • Link the documentation PR here
    • [Documentation PR link]

@imilinovic imilinovic self-assigned this Jan 5, 2026
@imilinovic imilinovic added this to the mage-v3.8.0 milestone Jan 5, 2026
@imilinovic imilinovic added Docs - changelog only Docs - changelog only bug bug labels Jan 5, 2026
@imilinovic imilinovic requested a review from Josipmrden January 5, 2026 16:12
@imilinovic imilinovic requested a review from DavIvek January 7, 2026 09:04
@imilinovic imilinovic enabled auto-merge January 8, 2026 12:50
@imilinovic imilinovic disabled auto-merge January 8, 2026 12:53
@imilinovic imilinovic enabled auto-merge January 8, 2026 12:56
@imilinovic imilinovic disabled auto-merge January 8, 2026 13:14
@imilinovic imilinovic enabled auto-merge January 8, 2026 13:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

@imilinovic imilinovic added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit b32e517 Jan 8, 2026
11 checks passed
@imilinovic imilinovic deleted the fix/migrate-threads branch January 8, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug bug Docs - changelog only Docs - changelog only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] migrate queries don't work for amount of results larger than 1000

3 participants