Skip to content

Conversation

@folkertdev
Copy link
Collaborator

the commits are self-contained so reviewing per-commit should work well.

@randomPoison
Copy link
Collaborator

randomPoison commented Feb 5, 2024

Ah, it looks like there's been some confusion about tasking! @fbossen is already working on cleaning up lf_apply.rs in #702. Would you be able to clean up one of the other files instead? Any of the "Cleanup c2rust output" tasks that aren't already assigned to someone would be good tasks to start with. Really sorry I didn't communicate that earlier.

@folkertdev
Copy link
Collaborator Author

totally! Depending on what is already done these changes might still be useful, so steal whatever makes sense. (really cleaning up this modules requires more structural changes, so if @fbossen started there there might be little overlap)

@fbossen
Copy link
Contributor

fbossen commented Feb 5, 2024

@folkertdev Unfortunately, looks like there isn't anything left to steal. I pushed my current changes to #728. Let me know if I missed something.

@folkertdev
Copy link
Collaborator Author

nothing significant no

@folkertdev folkertdev closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants