struct Rav1dFrameContext: Remove excess mutability and pointers from uses
#741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is a lot of changes to avoid doing them in more complicated PRs. This PR should have no functional changes. |
kkysen
requested changes
Feb 13, 2024
Collaborator
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
I think one of the dbg hoistings isn't the same since t.b{x,y} change in that function. I think we can split fn DEBUG_BLOCK_INFO into two methods on each arg so that they can be done separately.
rinon
force-pushed
the
sjc/rav1dframecontext/frame_thread_mutability
branch
from
0f682a3 to
174af54
Compare
rinon
force-pushed
the
sjc/debug_block_info_macro
branch
2 times, most recently
from
f3eae29 to
6df0fbc
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/frame_thread_mutability
branch
from
174af54 to
fe02a74
Compare
kkysen
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes excess mutability and replaces pointers to
struct Rav1dFrameContextwith references wherever possible, i.e. function arguments.