Skip to content

mod lr_apply: clean up code #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fbossen merged 15 commits into from
Feb 26, 2024
Merged

mod lr_apply: clean up code #746

fbossen merged 15 commits into from
Feb 26, 2024

Conversation

@fbossen
Copy link
Contributor

@fbossen fbossen commented Feb 14, 2024 •
edited
Loading

Fixes #704 :

  • restore comments from C code
  • use of slices instead of raw pointers where possible
  • general cleanup including removal of unnecessary casts, loop cleanup, and use of bool type where appropriate

kkysen
kkysen requested changes Feb 15, 2024
View reviewed changes
Frank Bossen added 15 commits February 23, 2024 06:40
lr_apply.rs: Restore comments from C file
1bac0ec
lr_apply.rs: remove unnecessary casts
abbfdf7
fn backup4xU: make dst argument a slice
ffbc981
fn lr_stripe: clean up assignment of filter parameters
90c8fbe
fn lr_sbrow: use bool type for binary variables bit and restore
79aef65
fn lr_stripe: use reference for dsp instead of pointer
d57cf2b
fn rav1d_lr_sbrow: use array reference instead of pointer for dst
a81d331 
Note: `dst` is now an array of pointers. Still need to make it am array
of slices
fn rav1d_lr_sbrow: remove _0 suffix from variable names
6c90b78
fn lr_stripe: make left parameter a slice
5b0b481
fn rav1d_lr_sbrow: use slice instead of raw pointer for dst
fc65445 
Also add a `dst_offset` parameter as indexing into the original
`dst` parameter could use negative offsets.
fn rav1d_lr_sbrow: avoid use of raw pointer
6ee07e9
fn lr_stripe: use slice instead of raw pointer for lpf variable
025b808
fn backup4xU: clean up loop
37032d4
Address PR comments
f633706
fn lr_stripe: add support for negative stride
c4537e3
@kkysen kkysen changed the title lr_apply.rs: clean up code mod lr_apply: clean up code Feb 26, 2024
@kkysen
Copy link
Collaborator

kkysen commented Feb 26, 2024

Addresses #704 :

Same as #728 (comment); can this be "fixes" instead of "addresses"?

@fbossen
Copy link
Contributor Author

fbossen commented Feb 26, 2024

Same as #728 (comment); can this be "fixes" instead of "addresses"?

I believe it can. Let me know if I missed something.

@fbossen fbossen merged commit 8096293 into memorysafety:main Feb 26, 2024
This was referenced Mar 12, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkysen kkysen kkysen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup c2rust output in mod lr_apply

2 participants

@fbossen @kkysen