Update ObjectQueueExecutor.java #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This chang is to fix an issue with a catched exception that is caused by a failing database transaction (for example not explicitly committed objects that are in the state 'Autocommitted'). Currently the process queue is only creating an info log but it is obviously an error. Changed it to error. Using the existing context for the setErrormessageAndCommit method is causing the changes made by his action to be rolled back with the entire transaction. I created a new system context to run this action. If you don't do that, the QueuedAction will remain in running forever, even if it is already terminated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chang is to fix an issue with a catched exception that is caused by a failing database transaction (for example not explicitly committed objects that are in the state 'Autocommitted'). Currently the process queue is only creating an info log but it is obviously an error. Changed it to error. Using the existing context for the setErrormessageAndCommit method is causing the changes made by his action to be rolled back with the entire transaction. I created a new system context to run this action. If you don't do that, the QueuedAction will remain in running forever, even if it is already terminated.