MAINT: refactoring #837
Merged
MAINT: refactoring #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
force-pushed
the
refactoring
branch
from
eb8ea9c to
adce222
Compare
rgommers
added
the
maintenance
rgommers
approved these changes
Jan 26, 2026
Contributor
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
Thanks @dnicolodi. Looks like an improvement, easier to read and harder to make a mistake.
Member
Author
|
It's some refactoring propaedeutic to the RPATH work. I'm trying to find time to get ti submitted and doing it in small steps is more compatible with the time I am able to dedicate to it. |
Contributor
|
Thanks, good to know. I'm in the same position, although at the moment it's relatively quiet so I'm hoping to get a few things done as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.