Skip to content

Remove ipv4 only any destination handling #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
majst01 wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Remove ipv4 only any destination handling #204

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c1e2f3
Remove ipv4 only any destination handling
majst01 Aug 21, 2025
00c861b
Fix
majst01 Aug 21, 2025
90a46db
Update go
majst01 Aug 21, 2025
81c247f
Fix
majst01 Aug 21, 2025
1361d36
Merge master
majst01 Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions pkg/nftables/networkpolicy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package nftables

import (
"fmt"
"net/netip"
"strings"

networkingv1 "k8s.io/api/networking/v1"
Expand Down Expand Up @@ -73,6 +74,11 @@ func clusterwideNetworkPolicyEgressDNSCacheRules(cache FQDNCache, logAcceptedCon
}, nil
}

var (
ipv4any = netip.MustParsePrefix("0.0.0.0/0")
ipv6any = netip.MustParsePrefix("::/0")
)

func clusterwideNetworkPolicyEgressRules(
cache FQDNCache,
np firewallv1.ClusterwideNetworkPolicy,
Expand All @@ -88,8 +94,20 @@ func clusterwideNetworkPolicyEgressRules(
rb = append(rb, fmt.Sprintf("ip daddr != { %s }", strings.Join(except, ", ")))
}
if len(allow) > 0 {
if allow[0] != "0.0.0.0/0" {
Copy link
Contributor Author

@majst01 majst01 Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is only the first allow entry considered ??

rb = append(rb, fmt.Sprintf("ip daddr { %s }", strings.Join(allow, ", ")))
destination, err := netip.ParsePrefix(allow[0])
if err != nil {
// TODO error handling
continue
}
if destination.Addr().Is4() {
if destination != ipv4any {
rb = append(rb, fmt.Sprintf("ip daddr { %s }", strings.Join(allow, ", ")))
}
}
if destination.Addr().Is6() {
if destination != ipv6any {
rb = append(rb, fmt.Sprintf("ip daddr { %s }", strings.Join(allow, ", ")))
}
}
}
ruleBases = append(ruleBases, ruleBase{base: rb})
Expand Down
Loading